Go: Avoid magic in TSynthLocation definition#16172
Merged
owen-mc merged 1 commit intogithub:mainfrom Apr 10, 2024
Merged
Conversation
This improves performance, because in this case magic is not beneficial.
hvitved
approved these changes
Apr 10, 2024
mbg
approved these changes
Apr 10, 2024
Contributor
Author
|
DCA uneventful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a performance problem in code introduced in #15853. The below numbers were obtained on
dolthub/go-mysql-server, but I have seen the evaluator do the same optimizations on other projects.Before:
After:
and